Increase provisioning timeouts #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To help deal with slow underlying storage, we need to adjust a few timeouts: bootstrapTimeout in init_oracle.go: Instance bootstrap involves file moves, three instance restarts and two Oracle "resetlogs" operations, all of which involve disk I/O. Here we increase the timeout from 19 to 29 minutes. * DatabaseInstanceReadyTimeoutSeeded in instance_controller.go: this timeout is set at the same time as bootstrapTimeout, but in the El Carro operator rather than in the destination database container. We set it to 1 minute more than bootstrapTimeout. * InstanceReadyTimeout in instance_controller.go: this timeout covers the actual creation of the pod, and notably provisioning any storage dependencies. This large increase is designed to cover storage platforms that provision multiple volumes (Data, Log, Backup) serially. * CallTimeout in dbdaemonlib.go: this timeout refers to dbdaemon calls after initial instance provisioning completes, notably CreateDatabase which creates an Oracle pluggable database, and again involves disk I/O. This change mirrors PR # 227, added here to hopefully make merging easier.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akinfermo, mfielding The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help deal with slow underlying storage, we need to adjust a few timeouts:
resetlogsoperations, all of which involve disk I/O. Here we increase the timeout from 19 to 29 minutes.CreateDatabasewhich creates an Oracle pluggable database, and again involves disk I/O. This change mirrors PR Increase default timeout for dbdaemon calls #227 , added here to hopefully make merging easier.