Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup restore test code #241

Merged
merged 1 commit into from Aug 24, 2022

Conversation

kurt-google
Copy link
Collaborator

This cleans up restore tests to use non-conflicting resource names so
that tests can fail independently. Previously if the first test failed
all other tests would fail due to not cleaning up resources.

Since this a functional test we dont really need to cleanup resources
we just need the tests to fail independently.

Change-Id: I73d64d9c7865bc66b5d8e9cd32d5a38fed93baad

This cleans up restore tests to use non-conflicting resource names so
that tests can fail independently. Previously if the first test failed
all other tests would fail due to not cleaning up resources.

Since this a functional test we dont really need to cleanup resources
we just need the tests to fail independently.

Change-Id: I73d64d9c7865bc66b5d8e9cd32d5a38fed93baad
Copy link
Collaborator

@akinfermo akinfermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kurt-google kurt-google merged commit 2dc06b0 into GoogleCloudPlatform:main Aug 24, 2022
@google-oss-prow google-oss-prow bot added the lgtm label Aug 24, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akinfermo, kurt-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akinfermo akinfermo added the testing Improvements or additions to testing label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L testing Improvements or additions to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants