Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user guide for DB credentials management using GSM #247

Merged
merged 1 commit into from Sep 8, 2022

Conversation

akinfermo
Copy link
Collaborator

b/245159113

Change-Id: I03e9a738b84d36bb2dae276847d4c24d0d925067

@akinfermo akinfermo added the documentation Improvements or additions to documentation label Sep 5, 2022
aravindous
aravindous previously approved these changes Sep 6, 2022
Copy link
Collaborator

@aravindous aravindous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change.

kurt-google
kurt-google previously approved these changes Sep 6, 2022
b/245159113

Change-Id: I03e9a738b84d36bb2dae276847d4c24d0d925067
Copy link
Collaborator

@kurt-google kurt-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up

@google-oss-prow google-oss-prow bot added the lgtm label Sep 8, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akinfermo, kurt-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akinfermo akinfermo merged commit c6aaa09 into GoogleCloudPlatform:main Sep 8, 2022
@akinfermo akinfermo deleted the docs/gsm-guide branch September 8, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved documentation Improvements or additions to documentation lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants