Add DbDaemon APIs for DB patching #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please also push the commit with an updated description, thanks. |
kurt-google
previously approved these changes
Sep 14, 2022
|
Yes, the merge commit will contain the updated description. |
Delete the GCSUtil interface from oracle/pkg/database/dbdaemon/utils.go because the code was moved to /oracle/pkg/util/utils.go in a previous commit. The deletion should have happened as part of that commit. Change-Id: I7447cabbccfb434cbb51da13bb5482e5c8dc3215
akinfermo
force-pushed
the
feature/patching-dbdaemon-apis
branch
from
4ffc774
to
f8f089b
Compare
kurt-google
approved these changes
Sep 14, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akinfermo, kurt-google The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete the GCSUtil interface from oracle/pkg/database/dbdaemon/utils.go because the code was moved to /oracle/pkg/util/utils.go in a previous commit. The deletion should have happened as part of that commit.
Change-Id: I7447cabbccfb434cbb51da13bb5482e5c8dc3215