Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting DEFERRED database parameters. #263

Merged

Conversation

nblxa
Copy link
Contributor

@nblxa nblxa commented Oct 20, 2022

Formerly, attempts to set parameters with ISSYS_MODIFIABLE = DEFERRED would have resulted in the error "ORA-02096: specified initialization parameter is not modifiable with this option". Example parameter: RECYCLEBIN.

@google-cla
Copy link

google-cla bot commented Oct 20, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@google-oss-prow
Copy link

Hi @nblxa. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Formerly, attempts to set parameters with ISSYS_MODIFIABLE = DEFERRED would have resulted in the error "ORA-02096: specified initialization parameter is not modifiable with this option". Example parameter: RECYCLEBIN.
@nblxa nblxa force-pushed the feature/deferred-parameters branch from ada62a2 to 7492999 Compare October 20, 2022 07:58
@akinfermo
Copy link
Collaborator

/ok-to-test

Copy link
Collaborator

@kurt-google kurt-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kurt-google, nblxa
Once this PR has been reviewed and has the lgtm label, please assign kaoet for approval by writing /assign @kaoet in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akinfermo akinfermo merged commit 2267161 into GoogleCloudPlatform:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants