Cleanup unused code and fixup labeling #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 19, 2022 14:40
We were using apt which may prompt, instead heed the warning and use apt-get and pass -y to agree to any potential prompts. Fixes presubmits. Change-Id: I4c6f7a77db7b70582f239cafe79eb413284a6fd6
This controller is mostly unused, it attempts to reconcile instances when a shared config change occurs but this violates the one controller for a resource principle and makes some upcoming changes harder. Instead let the instance controller eventually propagate changes from the configs. Future work would be to add a watcher on the config types from the instance controller similar to the PITR's watch on instances. Change-Id: Iab9c5e15e4bc01ab914fc915001d7ba8cc39a4c3
We have a number of labels that we use for matching against the various resources in El-Carro. This moves us towards a smaller set of more flexible labels. "instance" should be used to tag all resources associated with a particular instance "task-type" should be used to differentiate deployments by their purpose, right now just "database" but our agent deployments can also be migrated to this in the near future. Change-Id: Ib4b60b67e43a909065533e7400db56aea5e6145c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akinfermo, kurt-google The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some apt-get handling, removes the mostly unused config controller (Config CR functionality is unchanged by this), and starts to standardize our k8s resource labeling to align with better standards.