Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in standard metrics for oracle #279

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

kurt-google
Copy link
Collaborator

@kurt-google kurt-google commented Nov 11, 2022

This adds in queries for some standard metrics in oracle to support basic alerting.

It also removes the busybox image from the monitoring container as it was only there for testing.

Users of Google Managed Prometheus with Managed Collection enabled on their GKE cluster (or who have manually configured a prometheus stack using the Prometheus Collector) can use this example PodMonitoring to ingest these metrics.

apiVersion: monitoring.googleapis.com/v1
kind: PodMonitoring
metadata:
  name: prom-elcarro
spec:
  selector:
    matchLabels:
      task-type: monitor
  targetLabels:
    fromPod:
      - from: instance
        to: db_instance
  endpoints:
  - port: 9187
    interval: 5m

Change-Id: I82560b65e7fa55bf3c67a3ab58d99180df6b1026

This adds in queries for some standard metrics in oracle to support
basic alerting.

It also removes the busybox image from the monitoring container as it
was only there for testing.

Change-Id: I82560b65e7fa55bf3c67a3ab58d99180df6b1026
Copy link
Collaborator

@akinfermo akinfermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akinfermo, kurt-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurt-google kurt-google merged commit b3e1541 into GoogleCloudPlatform:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants