Fix backupschedule spec propagation #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes an issue that was preventing updates to backupschedule specs from getting propagated to CronAnything specs. For some reason, updating an entire CronAnything object in operations.go after updating the status of that same CronAnything object was causing new updates to the spec to disappear. To avoid this issue, we directly update CronAnything specs from backupschedule_controller.go. b/251830497 Change-Id: I3a5afd914fa50481ebbec4e350234aad86dadc2f
kurt-google
approved these changes
Nov 22, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akinfermo, kurt-google The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue that was preventing updates to backupschedule specs from getting propagated to CronAnything specs. For some reason, updating an entire CronAnything object in operations.go after updating the status of that same CronAnything object was causing new updates to the spec to disappear. To avoid this issue, we directly update CronAnything specs from backupschedule_controller.go.
b/251830497
Change-Id: I3a5afd914fa50481ebbec4e350234aad86dadc2f