Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Disk Resize Feature to El Carro. #299

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

tabbyl21
Copy link
Collaborator

@tabbyl21 tabbyl21 commented Dec 2, 2022

In this commit we add the logic necessary to allow disks to be resizeable. We add logic that checks if there were changes in the disk spec and if so creates a new sts that replaces the old sts. This commit also adds a test.

Change-Id: Id708f16016586ed1bbd1a59736dad112009918c8

In this commit we add the logic necessary to allow disks to be resizeable. We add logic that checks if there were changes in the disk
spec and if so creates a new sts that replaces the old sts. This commit also adds a test.

Change-Id: Id708f16016586ed1bbd1a59736dad112009918c8
@akinfermo akinfermo self-requested a review December 2, 2022 02:00
Copy link
Collaborator

@akinfermo akinfermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akinfermo, tabbyl21

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tabbyl21 tabbyl21 merged commit e5ddf62 into GoogleCloudPlatform:main Dec 2, 2022
@akinfermo akinfermo linked an issue Dec 8, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resizing of instances (CPU, RAM, Disks)
2 participants