Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for specified size of additional disks on Instance being ignored #376

Conversation

M-Schiefer
Copy link
Contributor

Fix for #371

Copy link

google-cla bot commented Mar 28, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

Hi @M-Schiefer. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akinfermo
Copy link
Collaborator

/ok-to-test

@akinfermo
Copy link
Collaborator

Hi @M-Schiefer , can you please sign the CLA https://cla.developers.google.com/? It's necessary for us to merge your contribution.

@M-Schiefer M-Schiefer force-pushed the feature/issue-371-additional-disk-sizes-fix branch 2 times, most recently from ff2e5f7 to 819811a Compare April 9, 2024 12:47
@M-Schiefer M-Schiefer force-pushed the feature/issue-371-additional-disk-sizes-fix branch from 819811a to cd25bea Compare April 9, 2024 12:49
@M-Schiefer
Copy link
Contributor Author

Hey @akinfermo, I fixed my CLA a while ago, but the operator-oss-presubmit failed.
Is there anything I still need to do here?

Thank you!

@akinfermo
Copy link
Collaborator

/retest

Copy link
Collaborator

@akinfermo akinfermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akinfermo, M-Schiefer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akinfermo akinfermo merged commit c0d8422 into GoogleCloudPlatform:main Apr 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants