Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): style View Campaign page #100

Merged
merged 5 commits into from
Jul 20, 2021
Merged

feat(website): style View Campaign page #100

merged 5 commits into from
Jul 20, 2021

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Jul 10, 2021

Fixes #64

Page layout screenshot

@ace-n ace-n requested a review from engelke July 10, 2021 00:47
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 10, 2021
@ace-n
Copy link
Contributor Author

ace-n commented Jul 10, 2021

Test failures look unrelated.

(FYI @dinagraves I think there's a bad filename somewhere.)

@dinagraves
Copy link
Contributor

dinagraves commented Jul 10, 2021

It's failing b/c the trigger is looking for the test config in the main branch but it hasn't been merged yet (#94). It will also fail anyway because you didn't write any tests :).

@dinagraves
Copy link
Contributor

Now it fails because you have no tests :)

Starting Step #2 - "Unit Tests"
Step #2 - "Unit Tests": Already have image: python:3.9-slim
Step #2 - "Unit Tests": ============================= test session starts ==============================
Step #2 - "Unit Tests": platform linux -- Python 3.9.6, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
Step #2 - "Unit Tests": rootdir: /workspace/website
Step #2 - "Unit Tests": collected 0 items
Step #2 - "Unit Tests": 
Step #2 - "Unit Tests": ============================ no tests ran in 0.01s =============================
Finished Step #2 - "Unit Tests"
ERROR
ERROR: build step 2 "python:3.9-slim" failed: step exited with non-zero status: 5

website/sample_data.py Outdated Show resolved Hide resolved
website/views/campaigns.py Outdated Show resolved Hide resolved
</div>

<!-- Campaign info (top right quadrant) -->
<div class="emblem-campaign-details mdc-layout-grid__cell mdc-layout-grid__cell--span-6">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussion: We've generally been using HTML4 markup in this project, I think we should consider using more semantic HTML5 markup. For example, using main, section, aside, header, and footer in lieu of many divs.

Raising this because I think we're approaching a stage where it goes from "revising to meet a new standard" to "planning a refactoring strategy"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but I think this is best addressed as a codebase-wide refactor (since other already-styled pages do the same thing).

I filed #106 to track this effort.

@ace-n
Copy link
Contributor Author

ace-n commented Jul 13, 2021

@dinagraves - @engelke and I will have to discuss a larger frontend/website testing plan going forward.

That's probably not going to be addressed for a few weeks, though. (Ideally, I'd like to get the website fully styled first.)

website/sample_data.py Show resolved Hide resolved
@dinagraves
Copy link
Contributor

@dinagraves - @engelke and I will have to discuss a larger frontend/website testing plan going forward.

That's probably not going to be addressed for a few weeks, though. (Ideally, I'd like to get the website fully styled first.)

Sure - you have a few options then. Either someone who has override power can merge the PR, or you can write a simple "test" that just does assert True, so it keeps the pytest check happy.

@grayside grayside added this to the v0.5.0 milestone Jul 19, 2021
@ace-n ace-n merged commit 7984519 into main Jul 20, 2021
@ace-n ace-n deleted the style-view branch July 20, 2021 00:09
grayside pushed a commit that referenced this pull request Jul 22, 2021
* feat(website): style View Campaign Details page

* Address comments

* Placate pytest

Co-authored-by: Dina Graves Portman <dinagraves@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Style the "View Campaign" page
4 participants