Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(CI): fix Python lint issues #137

Merged
merged 2 commits into from
Aug 2, 2021
Merged

chore(CI): fix Python lint issues #137

merged 2 commits into from
Aug 2, 2021

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Aug 2, 2021 •
edited
Loading

Fixes bot noise in #129

(These are only changes from black, nothing else.)

@ace-n ace-n requested a review from engelke August 2, 2021 21:58
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 2, 2021
engelke
engelke requested changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should run black on generated files at all. This would create a continuing problem every time the generated library is updated.

@ace-n ace-n requested a review from engelke August 2, 2021 22:19
github-actions[bot]
github-actions bot reviewed Aug 2, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • website/sample_data.py
    • lines 58-58

@ace-n ace-n mentioned this pull request Aug 2, 2021
Closed
engelke
engelke approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ace-n ace-n merged commit 687aac4 into main Aug 2, 2021
@ace-n ace-n deleted the black-lint branch August 2, 2021 22:28
@grayside grayside added this to the v0.5.0 milestone Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@engelke engelke engelke approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ace-n @engelke @grayside