Straw man for approvers resource #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
Addresses issue #12 |
dinagraves
reviewed
May 21, 2021
content-api/server/main.py
Outdated
|
|
||
|
|
||
| @app.route('/approvers/', defaults={'approver': None}, methods=['GET', 'POST']) | ||
| @app.route('/approvers/<string:approver>', methods=['GET', 'PUT', 'DELETE', 'PATCH']) |
There was a problem hiding this comment.
May I suggest breaking this up into different functions for testability / readability? eg
@app.route('/approvers/<string:approver>', methods=['GET'])
def get_approvers(approver):
if approver is None:
return approvers.list()
return approvers.get(approver)
@app.route('/approvers/<string:approver>', methods=['POST'])
def post_approvers(approver):
. . .
return approvers.insert(body)
There was a problem hiding this comment.
I think it's testable as is, but it's sure a lot less readable than it could be. Will be doing this.
grayside
requested changes
May 21, 2021
grayside
approved these changes
May 24, 2021
There was a problem hiding this comment.
Thanks for responding to my feedback @engelke. My takeaway is that the term strawman here is presenting this change as a "pretotype v2" for the API. In that light, the code and decisions made here are not intended as a first iteration: the lessons we're learning here are about the API design and learning how the website will integrate with this backend.
This was referenced May 27, 2021
grayside
pushed a commit
that referenced
this pull request
Jul 22, 2021
* Straw man for approvers resource * Prepare for generic resource handling * More readable, ready for another resource * Reuse cached firestore client * Instructions to run locally * Handle invalid resource names * Add donors resource * Let black format this code * Enforce optional etag matching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.