Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): support env var configs #171

Merged
merged 2 commits into from
Sep 9, 2021
Merged

feat(website): support env var configs #171

merged 2 commits into from
Sep 9, 2021

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Sep 8, 2021

This migrates the existing (hard-coded) config.default.py values to environment variables fetched by config.py.

It also adds an EMBLEM_API_URL environment variable instead of hard-coding the API URL.

Fixes #170; related to #152.

@ace-n ace-n requested a review from a team as a code owner September 8, 2021 21:39
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 8, 2021
@ace-n ace-n linked an issue Sep 8, 2021 that may be closed by this pull request
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ace-n ace-n merged commit 53ff8b3 into main Sep 9, 2021
@ace-n ace-n deleted the env-cfg branch September 9, 2021 00:02
@grayside grayside added this to the v0.5.0 milestone Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website changes on config management
4 participants