fix(Content API client libs): workaround generated libraries issue #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated libraries are ignoring conf.access_token, so force the header that they should be creating.
google-cla
bot
added
the
cla: yes
ace-n
reviewed
Sep 16, 2021
| client = DefaultApi(api_client=ApiClient( | ||
| configuration=conf, | ||
| header_name="Authorization", | ||
| header_value=access_token, |
There was a problem hiding this comment.
Do we need the Bearer: part here?
There was a problem hiding this comment.
Well. Yes. Check again in a minute.
ace-n
changed the title
ace-n
approved these changes
Sep 16, 2021
grayside
approved these changes
Sep 16, 2021
| @@ -29,10 +29,19 @@ class EmblemClient(object): | |||
| def __init__(self, host, access_token=None): | |||
| conf = Configuration() | |||
|
|
|||
| # TODO: figure out why the generated code isn't using the value below | |||
There was a problem hiding this comment.
nit: Thanks for adding the TODO. Reading just the updated code, it's unclear to me what we're saying is not being used. More detail would be helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated libraries are ignoring conf.access_token, so force the header that they should be creating.