feat(website): add "View campaign" and "Create campaign" page wireframes #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
grayside
approved these changes
May 24, 2021
| @@ -16,6 +16,8 @@ | |||
| <!doctype html> | |||
| <title>View Campaigns | Cymbal Giving</title> | |||
|
|
|||
| <a href="/createCampaign">Create new campaign</a> | |||
|
|
|||
| {% for campaign in campaigns %} | |||
| <div> | |||
There was a problem hiding this comment.
suggestion: This template is a good starting place, but as we iterate the markup in the future I think we should embrace HTML5 for improved semantics, more out-of-box accessibility, and a general "modern" feeling for frontend-savvy developers.
|
@dinagraves I'm going to merge this as-is to avoid having to rebase my next PR. Please ping me if you'd like me to change anything! |
ace-n
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did these in one PR to avoid merge conflicts between the two. However, changes should be split on the commit level.
Fixes #16 and #17