Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): migrate 3 decisions to new format (jinja, views, monorepo) #208

Merged
merged 2 commits into from
Oct 6, 2021
Merged

chore(docs): migrate 3 decisions to new format (jinja, views, monorepo) #208

merged 2 commits into from
Oct 6, 2021

Conversation

grayside
Copy link
Collaborator

@grayside grayside commented Oct 5, 2021

Follow-up to #178

@grayside grayside added the type: docs Improvement to the documentation for an API. label Oct 5, 2021
@grayside grayside self-assigned this Oct 5, 2021
@grayside grayside requested a review from a team as a code owner October 5, 2021 21:48
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 5, 2021
@grayside grayside added this to the v0.5.0 milestone Oct 5, 2021
iennae
iennae approved these changes Oct 6, 2021
View reviewed changes
Copy link
Collaborator

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though would have been helpful to have more details rather than just linking back to the previous issue.

@grayside grayside merged commit f7fc7cd into main Oct 6, 2021
@grayside grayside deleted the decision-migration-r2 branch October 6, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iennae iennae iennae approved these changes

Assignees

@grayside grayside

Labels
cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grayside @iennae