Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(demo services): incorrect API quickstart "Open in Cloud Shell" link #215 #216

Merged
merged 1 commit into from
Oct 18, 2021
Merged

fix(demo services): incorrect API quickstart "Open in Cloud Shell" link #215 #216

merged 1 commit into from
Oct 18, 2021

Conversation

kelsk
Copy link
Contributor

@kelsk kelsk commented Oct 15, 2021

Minor fix to launch the tutorial in Cloud Shell

@kelsk kelsk added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. component: demo services Related to interactive learning using the app. labels Oct 15, 2021
@kelsk kelsk requested a review from a team as a code owner October 15, 2021 23:01
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 15, 2021
engelke
engelke approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelke engelke merged commit f79702e into main Oct 18, 2021
@engelke engelke deleted the kelsk-fix1 branch October 18, 2021 16:38
@grayside grayside added this to the v0.6.0 milestone Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelke engelke engelke approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. component: demo services Related to interactive learning using the app. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kelsk @engelke @grayside