-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(design): view donation page (punch list) #291
Conversation
refactor: minor templating fix
…tamp ref refactor: minor fix, moving address/name input to be updated under donor refactor: cleaning up
refactor: reformatting main_nonapprover_test
b99322a
to
f8f97dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with comments:
1 - I don't know why the error on the API tests occurred because I don't seem to have permission to view the test results. It's going to need to be fixed - let's see how to get the needed permission.
2 - For now, it's okay to fill in the mailing address as a dictionary, but it would be better to format it as multiple lines, as in:
123 Main St.
Anytown, WA 99999
I'm also have trouble viewing that result. It looks to me like this is the most recent test run: https://console.cloud.google.com/cloud-build/builds;region=global/bac39fad-fd51-40c3-a6f0-c3bf51bd073f?project=emblem-ops (and is passing). |
Rerunning, it failed again and I don't see the build in Cloud Console. |
@dinagraves noted we have redundant triggers in place, from a test on spinning up a new Emblem instance that reused our main repository. These checks were not deleted after the test. The check is still showing as failed, but Dina has cleaned up the underlying bits and the check is no longer blocking merge. Proceed when ready. |
Related to task: #288
Emblem punch list: https://docs.google.com/document/d/1lfO6xWmqfpqa1q4XlbbRmzUpEAaeWg9wMQ0MwrMxL-c/edit?usp=sharing
Items to verify (from above master list)
Steps to test PR through my local project:
If you go this route, let me know so I can add you manually as an
approver
in the project. (Required in order to login)I also may need to redeploy.
api: https://api-byccf5bkda-uc.a.run.app
website: https://website-byccf5bkda-uc.a.run.app/
Steps to test PR locally in your personal project: (Cloud Shell)
Copy
client-libs/
directory from root intowebsite/
directory before building the image / deploying (itsDockerfile
requires the directory)Build image based on
content-api/
directory and deploy in container w/ Cloud Run (name:api
)Build image based on
website/
directory and deploy in container w/ Cloud Run (name:website
)From project root, run
. scripts/configure_auth.sh
(Requires website container to exist)Verify the above listed checklist items.
Drive of personal scripts used:
https://drive.google.com/drive/folders/1knOSYk4EKQcuke5wvCMVVB-ifJN7JgNO?usp=sharing