Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): view campaign page (punch list) #292

Merged
merged 3 commits into from
Jan 4, 2022

Conversation

pattishin
Copy link
Collaborator

@pattishin pattishin commented Dec 22, 2021

Related to task: #272

Emblem punch list: https://docs.google.com/document/d/1lfO6xWmqfpqa1q4XlbbRmzUpEAaeWg9wMQ0MwrMxL-c/edit?usp=sharing

Items to verify (from above master list)

  • GET /viewCampaign shows the donor ID, not the donor name, in donation history. No date is displayed. Is the name needed? Yes, if the viewer is a campaign manager, no if it is only a donor.
  • GET /viewCampaign shows the date in ISO format, down to the microsecond. It's also in Zulu time.
  • GET /viewCampaign doesn't show the raised amount or the created date
  • Magnifying glass icon should be removed, we don't have upcoming plans for a search feature
  • Login/logout icons are non-standard, material icons have specific login/logout icons.

Steps to test PR through my local project:

If you go this route, let me know so I can add you manually as an approver in the project. (Required in order to login)
I also may need to redeploy.

api: https://api-byccf5bkda-uc.a.run.app
website: https://website-byccf5bkda-uc.a.run.app/

Steps to test PR locally in your personal project: (Cloud Shell)

  1. Ensure you have your local setup like so:
  1. Copy client-libs/ directory from root into website/ directory before building the image / deploying (its Dockerfile requires the directory)

  2. Build image based on content-api/ directory and deploy in container w/ Cloud Run (name: api)

  3. Build image based on website/ directory and deploy in container w/ Cloud Run (name: website)

  4. From project root, run . scripts/configure_auth.sh (Requires website container to exist)

  5. Verify the above listed checklist items.

Drive of personal scripts used: (poor man's scripting)
https://drive.google.com/drive/folders/1knOSYk4EKQcuke5wvCMVVB-ifJN7JgNO?usp=sharing

Screen Shot 2021-12-22 at 11 23 39 AM

…ampaign

refactor: adding helpers (time/donor)
@pattishin pattishin requested a review from a team as a code owner December 22, 2021 19:25
@pattishin pattishin linked an issue Dec 22, 2021 that may be closed by this pull request
5 tasks
@pattishin pattishin self-assigned this Dec 23, 2021
@pattishin pattishin force-pushed the feat/view-campaign-page-updated branch 2 times, most recently from d12dd1c to 2b59268 Compare January 4, 2022 17:35
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I particularly like the new login/logout icon. It's much clearer to me which icon means what.

@engelke engelke added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2022
@engelke engelke merged commit 1055988 into main Jan 4, 2022
@engelke engelke deleted the feat/view-campaign-page-updated branch January 5, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(design): view campaign page (punch list)
2 participants