Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

feat(design): general site bugs (punch list) #293

Merged
merged 5 commits into from
Jan 14, 2022
Merged

Conversation

pattishin
Copy link
Collaborator

@pattishin pattishin commented Dec 23, 2021

Related to task: #289

Emblem punch list: https://docs.google.com/document/d/1lfO6xWmqfpqa1q4XlbbRmzUpEAaeWg9wMQ0MwrMxL-c/edit?usp=sharing

Items to verify (from above master list)

  • Hero image on homepage is not full width, and not responsive
  • No link to the home page, such as the site title in the app bar.
  • Campaign cards on home page look like more of them should be "hot" for click-through to View Campaign, but only the View Campaign text is linked

Steps to test PR through my local project:

If you go this route, let me know so I can add you manually as an approver in the project. (Required in order to login)
I also may need to redeploy.

api: https://api-byccf5bkda-uc.a.run.app
website: https://website-byccf5bkda-uc.a.run.app/

Steps to test PR locally in your personal project: (Cloud Shell)

  1. Ensure you have your local setup like so:
  1. Copy client-libs/ directory from root into website/ directory before building the image / deploying (its Dockerfile requires the directory)

  2. Build image based on content-api/ directory and deploy in container w/ Cloud Run (name: api)

  3. Build image based on website/ directory and deploy in container w/ Cloud Run (name: website)

  4. From project root, run . scripts/configure_auth.sh (Requires website container to exist)

  5. Verify the above listed checklist items.

Drive of personal scripts used: (poor man's scripting)
https://drive.google.com/drive/folders/1knOSYk4EKQcuke5wvCMVVB-ifJN7JgNO?usp=sharing

Screen Shot 2021-12-22 at 4 18 19 PM

@pattishin pattishin requested a review from a team as a code owner December 23, 2021 00:36
@pattishin pattishin linked an issue Dec 23, 2021 that may be closed by this pull request
3 tasks
@pattishin pattishin self-assigned this Jan 4, 2022
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm missing something, it looks like all the images are gone in this commit. We need them restored or my error explained.

@pattishin
Copy link
Collaborator Author

@engelke Ah, that's due do the browser caching. If you can either clear your browser cache (images/files) or go incognito, I believe the images should pop up again. The urls referencing them just got relocated to the css.
Let me know if it's still an issue!

@engelke
Copy link
Contributor

engelke commented Jan 5, 2022

Yep, there are images there now. But each campaign has it's own separate image, stored in the campaigns collection. I don't think you can do that with the CSS. As of now, all the campaigns have the same image.

@pattishin
Copy link
Collaborator Author

pattishin commented Jan 14, 2022

Sorry for the delay @engelke and thanks for catching that bug! Should've run this with more than one campaign loaded. It should be fixed now! (screenshot below)

Screen Shot 2022-01-14 at 12 09 09 PM

Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelke engelke merged commit 668edbc into main Jan 14, 2022
@engelke engelke deleted the bugfix/general-site-fixes branch January 14, 2022 23:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(design): general site bugs (punch list)
2 participants