-
Notifications
You must be signed in to change notification settings - Fork 61
feat(design): general site bugs (punch list) #293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I'm missing something, it looks like all the images are gone in this commit. We need them restored or my error explained.
@engelke Ah, that's due do the browser caching. If you can either clear your browser cache (images/files) or go incognito, I believe the images should pop up again. The urls referencing them just got relocated to the css. |
Yep, there are images there now. But each campaign has it's own separate image, stored in the campaigns collection. I don't think you can do that with the CSS. As of now, all the campaigns have the same image. |
Sorry for the delay @engelke and thanks for catching that bug! Should've run this with more than one campaign loaded. It should be fixed now! (screenshot below) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related to task: #289
Emblem punch list: https://docs.google.com/document/d/1lfO6xWmqfpqa1q4XlbbRmzUpEAaeWg9wMQ0MwrMxL-c/edit?usp=sharing
Items to verify (from above master list)
Steps to test PR through my local project:
If you go this route, let me know so I can add you manually as an
approver
in the project. (Required in order to login)I also may need to redeploy.
api: https://api-byccf5bkda-uc.a.run.app
website: https://website-byccf5bkda-uc.a.run.app/
Steps to test PR locally in your personal project: (Cloud Shell)
Copy
client-libs/
directory from root intowebsite/
directory before building the image / deploying (itsDockerfile
requires the directory)Build image based on
content-api/
directory and deploy in container w/ Cloud Run (name:api
)Build image based on
website/
directory and deploy in container w/ Cloud Run (name:website
)From project root, run
. scripts/configure_auth.sh
(Requires website container to exist)Verify the above listed checklist items.
Drive of personal scripts used: (poor man's scripting)
https://drive.google.com/drive/folders/1knOSYk4EKQcuke5wvCMVVB-ifJN7JgNO?usp=sharing