-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): add Setup Quickstart tutorial #308
Conversation
docs/tutorials/setup-walkthrough.md
Outdated
## Introduction | ||
|
||
In this tutorial, you'll set up the Emblem application by following these steps: | ||
1. run a script to deploy Emblem to [Cloud Run](https://cloud.google.com/run) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: capitalize these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit accepted ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you forgot to push an updated version of setup-walkthrough.md
?
Other than that (and a few other nits), LGTM. 🙂
Co-authored-by: Ace Nassri <anassri@google.com>
Co-authored-by: Ace Nassri <anassri@google.com>
Co-authored-by: Ace Nassri <anassri@google.com>
@ace-n Thank you! Yep, I forgot to push the changes up 😅 |
Add
setup-quickstart.md
which contains instructions on deploying Emblem using the setup script.Add
setup-walkthrough.md
which contains similar instructions configured to run as a Neos interactive walkthrough tutorial. (Test the walkthrough using this link: Open in Cloud Shell)Limitations
The tutorials do not include detailed Next steps. This should not be a blocker for adding the initial tutorials, but adding detailed next steps should be a priority in the short term.