Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): draft blueprint architecture + add error handlers #38

Merged
merged 2 commits into from
Jun 10, 2021

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented May 27, 2021

Fixes #34.

I will propagate the Blueprints and Templates refactors to other views in future PRs once we agree on them as a team.

@ace-n ace-n requested review from grayside and dinagraves May 27, 2021 03:37
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 27, 2021
@ace-n ace-n requested a review from engelke May 27, 2021 03:38
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with non-blocking comments for consideration.

website/templates/errors/500.html Outdated Show resolved Hide resolved
website/templates/errors/500.html Show resolved Hide resolved
website/templates/errors/base.html Outdated Show resolved Hide resolved
@ace-n ace-n merged commit 110bc3c into main Jun 10, 2021
@ace-n ace-n deleted the error-handlers branch June 10, 2021 01:04
ace-n pushed a commit that referenced this pull request Jun 10, 2021
* Draft blueprint architecture + add error handlers

* Address Charlie's comments
grayside pushed a commit that referenced this pull request Jul 22, 2021
* Draft blueprint architecture + add error handlers

* Address Charlie's comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create error-handling (Flask) routes
3 participants