This repository has been archived by the owner on Jul 25, 2024. It is now read-only.
testing: convert conventional commit PR titles to labels #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ace-n
approved these changes
May 18, 2022
| uses: bcoe/conventional-release-labels@v1 | ||
| with: | ||
| type_labels: | ||
| feat: 'type: feature request' |
There was a problem hiding this comment.
Nit: should we have one for the chore prefix?
There was a problem hiding this comment.
The default behavior (if I recall) was to exclude that, and let issues fall into miscellaneous bucket. My thought was to test what happens a bit and refine.
| type_labels: | ||
| feat: 'type: feature request' | ||
| fix: 'type: bug' | ||
| breaking: 'semver: major' |
There was a problem hiding this comment.
Nit: does this accept the "exclamation mark" notation?
(i.e. feat!(website): move from Flask to Lit)
There was a problem hiding this comment.
It should detect this as a breaking change and flag as semver: major
There was a problem hiding this comment.
Also: We can use the component in the title if we want, but my next PR will auto-assign component labels based on files changed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #360. It lifts conventional commit prefixes from PR titles to labels, where the GitHub release notes can pick up things like breaking changes per the configuration in #382. These labels also help ensure the write labels are on the PRs, avoiding metadata gaps or manual work where the prefixes are used correctly.