feat(setup.sh): add skips for non-automated processes #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grayside
approved these changes
May 19, 2022
setup.sh
Outdated
| project=${OPS_PROJECT}" | ||
| echo "Connect your repos: ${REPO_CONNECT_URL}" | ||
| python3 -m webbrowser ${REPO_CONNECT_URL} | ||
| if [[ -z "${SKIP_REPO_CONNECTION}" ]]; then |
There was a problem hiding this comment.
Per #364, we need to remove the repo connection steps from setup.sh and make sure script/terraform is updated to take care of things e2e. I assume that means needing to get the new terraform experiment into place.
I think that means: doing this is fine to unblock testing, but we shouldn't spend much time on it as it will be removed in 2-3 weeks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the stage for future work on automated Delivery testing.
This adds two environment variables to
setup.sh:SKIP_AUTHSKIP_TRIGGERSSetting these environment variables will enable programmatic deployments of Emblem using
setup.sh.