-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(terraform): integrate modular terraform #476
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rogerthatdev
commented
Jun 3, 2022
- experimental-setup.sh will deploy resources to the ops, staging, and prod projects and optionally run the configure_auth script.
- Deploying triggers is disabled until we integrate them properly into the emblem-app module.
grayside
approved these changes
Jun 3, 2022
We're going to be aggressive in merging this and working to fix up anything that creates a challenge in follow-up. Per discussion, Cloud Build triggers are partially implemented a two ways, and neither of them are quite what we want. Correcting that will be in a follow-up. I will file issues later clarifying those actions, which includes rehoming ownership of triggers to app environments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: delivery
Related to automation, testing, deployment of the application.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.