feat(delivery): integrate TF refactor into cleanup script #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: delivery
github-actions
bot
added
type: feature request
grayside
reviewed
Jun 6, 2022
| @@ -137,7 +137,7 @@ gcloud scheduler jobs delete nightly-builds \ | |||
| || true | |||
|
|
|||
| # Remove existing Terraform state (Part 1) | |||
| pushd "terraform/ops" | |||
| pushd terraform/environments/ops | |||
| terraform init | |||
| terraform apply \ | |||
There was a problem hiding this comment.
future change: could we switch to terraform destroy for brevity and clarity? This through me a bit as I was trying to figure out why a cleanup script was creating resources.
grayside
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #397; will be rebased into #482