-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: reorganize installation testing TF + add builds #530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally seems good, but want to check: are we using the same pub/sub topic for both nightly system and deployment tests? Are there any shared resources that could end up in contention?
The website system tests are not currently running nightly; rather, they run against That said, building and testing resources on the same topic can cause race conditions (primarily, using the previous day's artifacts in test runs). I'd argue that we should consider address the race condition issue in a follow-on PR by creating two separate topics -
|
Let's explore that as a follow-up design discussion. For now it sounds like this is not a source of conflicts. |
data.tf
file, and moved thegoogle_project
resource therepresubmit
) and Installation Testing (nightly
).delivery_testing.tf
file toiam.tf
✅ I've tested this, and all triggers are passing.