Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: reorganize installation testing TF + add builds #530

Merged
merged 4 commits into from
Jun 10, 2022
Merged

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Jun 10, 2022

  • Added a data.tf file, and moved the google_project resource there
  • Added Cloud Build triggers for Delivery Image building (presubmit) and Installation Testing (nightly).
  • Renamed the (mostly IAM resource-based) delivery_testing.tf file to iam.tf

✅ I've tested this, and all triggers are passing.

@ace-n ace-n requested a review from a team as a code owner June 10, 2022 01:01
@github-actions github-actions bot added semver: major Hint for users that this is an API breaking change. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. semver: major Hint for users that this is an API breaking change. labels Jun 10, 2022
@ace-n ace-n self-assigned this Jun 10, 2022
@ace-n ace-n requested a review from grayside June 10, 2022 01:20
@github-actions github-actions bot added semver: major Hint for users that this is an API breaking change. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. semver: major Hint for users that this is an API breaking change. labels Jun 10, 2022
Copy link
Collaborator

@grayside grayside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally seems good, but want to check: are we using the same pub/sub topic for both nightly system and deployment tests? Are there any shared resources that could end up in contention?

@ace-n
Copy link
Contributor Author

ace-n commented Jun 10, 2022

The website system tests are not currently running nightly; rather, they run against localhost upon presubmit.

That said, building and testing resources on the same topic can cause race conditions (primarily, using the previous day's artifacts in test runs).

I'd argue that we should consider address the race condition issue in a follow-on PR by creating two separate topics - nightly_builds and nightly_tests, where the latter runs ~1 hour after the former.

Note: I'm not 100% sure I'll get to that tomorrow, so if it's a blocker perhaps you and Charlie / Patti could pair on it? I'm also happy to take a "first stab" and let one of y'all get it over the finish line.

@grayside
Copy link
Collaborator

Let's explore that as a follow-up design discussion. For now it sounds like this is not a source of conflicts.

@ace-n
Copy link
Contributor Author

ace-n commented Jun 10, 2022

@grayside filed as #533

@ace-n ace-n merged commit 4737a14 into main Jun 10, 2022
@ace-n ace-n deleted the delivery-nightly branch June 10, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: major Hint for users that this is an API breaking change. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants