Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issue-608): hide create campaign link #624

Merged
merged 2 commits into from
Aug 17, 2022
Merged

fix(issue-608): hide create campaign link #624

merged 2 commits into from
Aug 17, 2022

Conversation

pattishin
Copy link
Collaborator

Resolves issue: #608

Fix: Instead of disabling button, I've decided to hide it. If this is never to be enabled for someone
just perusing incognito, it should only be displayed for logged in users.

Steps to recreate:

  1. Check branch out and rebuild website/ image and redeploy on your personal GCP
  2. Without logging in, you should no longer see the button displayed on the homepage
  3. Go through login and when you've landed back on the homepage you should see the button displayed again

Note: Happy to let you leverage my GCP project if necessary to review this. I will just need to add you as an approver.

Screen Shot 2022-08-16 at 6 54 44 PM

Screen Shot 2022-08-16 at 6 55 00 PM

refactor: minor ui fixes

refactor: minor clean up
@pattishin pattishin requested a review from a team as a code owner August 17, 2022 02:08
@github-actions github-actions bot added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. component: website Related to the application frontend. labels Aug 17, 2022
website/templates/home.html Outdated Show resolved Hide resolved
website/views/campaigns.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 17, 2022
@pattishin pattishin merged commit 7020c16 into main Aug 17, 2022
@pattishin pattishin deleted the fix/issue-608 branch August 17, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: website Related to the application frontend. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants