Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: automatically run tests for renovate-bot PRs #640

Merged
merged 5 commits into from
Sep 29, 2022
Merged

fix: automatically run tests for renovate-bot PRs #640

merged 5 commits into from
Sep 29, 2022

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Aug 19, 2022 •
edited
Loading

@grayside do we want to use dpebot here?

While it's definitely useful, I worry that Google-specific config might distract/confuse end-users.

@ace-n ace-n requested a review from a team as a code owner August 19, 2022 21:30
@github-actions github-actions bot added persona: maintainer [meta] Related to project maintenance. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 19, 2022
@github-actions github-actions bot added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 24, 2022
@github-actions github-actions bot added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 6, 2022
grayside
grayside approved these changes Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@grayside grayside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we should (future) explicitly document that we do this as part of how we drive testing with Cloud Build.

@github-actions github-actions bot added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 23, 2022
@rogerthatdev rogerthatdev merged commit bef9e54 into main Sep 29, 2022
@github-actions github-actions bot added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 29, 2022
@pattishin pattishin deleted the dpebot-renovate branch December 9, 2022 21:44
@github-actions github-actions bot mentioned this pull request Jan 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grayside grayside grayside approved these changes

Assignees
No one assigned
Labels
persona: maintainer [meta] Related to project maintenance. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ace-n @grayside @rogerthatdev @pattishin