Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Terraform to seed approver and donors test data to Firestore #644

Merged
merged 11 commits into from
Aug 26, 2022

Conversation

rogerthatdev
Copy link
Contributor

@rogerthatdev rogerthatdev commented Aug 25, 2022

This adds the following to the emblem-app terraform module:

  • an approver_email variable used to indicate an initial 'approver' to add to Firebase
  • a boolean seed_test_data variable, set to false by default, that toggles Firestore document resources
  • a Firestore document resource using approver_email in an 'approvers' collection
  • a Firestore document resource for each object in a donors.json file

The above uses Terraform templates and json files made up from data in sample_data.json

Note: merging this PR will not change any Terraform functionality. The seed_test_data variable used is set to false by default so that none of the resources associated with test data is added. The resources in this module will remain dormant until seed_test_data is set to true

This will only partially address #602
Forthcoming PRs will add test data for campaigns, causes, and donations.

@github-actions github-actions bot added the component: delivery Related to automation, testing, deployment of the application. label Aug 25, 2022
@rogerthatdev rogerthatdev marked this pull request as ready for review August 25, 2022 06:13
@rogerthatdev rogerthatdev requested a review from a team as a code owner August 25, 2022 06:13
"stringValue": "approvers"
},
"name": {
"stringValue": "Seeded test user"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Seeded approver" would be better for the name

Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: delivery Related to automation, testing, deployment of the application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants