-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Terraform to seed approver and donors test data to Firestore #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engelke
reviewed
Aug 26, 2022
"stringValue": "approvers" | ||
}, | ||
"name": { | ||
"stringValue": "Seeded test user" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Seeded approver" would be better for the name
engelke
approved these changes
Aug 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Aug 26, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following to the emblem-app terraform module:
approver_email
variable used to indicate an initial 'approver' to add to Firebaseseed_test_data
variable, set tofalse
by default, that toggles Firestore document resourcesapprover_email
in an 'approvers' collectiondonors.json
fileThe above uses Terraform templates and json files made up from data in sample_data.json
Note: merging this PR will not change any Terraform functionality. The
seed_test_data
variable used is set tofalse
by default so that none of the resources associated with test data is added. The resources in this module will remain dormant untilseed_test_data
is set totrue
This will only partially address #602
Forthcoming PRs will add test data for campaigns, causes, and donations.