Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(delivery): rename some build triggers #682

Merged
merged 11 commits into from
Oct 19, 2022

Conversation

rogerthatdev
Copy link
Contributor

@rogerthatdev rogerthatdev commented Sep 29, 2022

Partially addresses #669

This PR will:

  • rename the api-push-to-main trigger to api-new-build
  • rename the web-push-to-main trigger to web-new-build
  • rename the web-system-tests trigger to web-e2e-test
  • add a description for each

This change renames Terraform resources so will destroy and create build trigger resources;
There is no documentation that includes these trigger names

@github-actions github-actions bot added the component: delivery Related to automation, testing, deployment of the application. label Sep 29, 2022
@rogerthatdev rogerthatdev marked this pull request as ready for review September 29, 2022 01:54
@rogerthatdev rogerthatdev requested a review from a team as a code owner September 29, 2022 01:54
terraform/modules/ops/build.tf Outdated Show resolved Hide resolved
terraform/modules/ops/build.tf Outdated Show resolved Hide resolved
terraform/modules/ops/build.tf Show resolved Hide resolved
terraform/modules/ops/build.tf Show resolved Hide resolved
terraform/modules/ops/testing.tf Outdated Show resolved Hide resolved
rogerthatdev and others added 3 commits October 4, 2022 14:54
Co-authored-by: Adam Ross <adamross@google.com>
Co-authored-by: Adam Ross <adamross@google.com>
terraform/modules/ops/build.tf Outdated Show resolved Hide resolved
terraform/modules/ops/testing.tf Outdated Show resolved Hide resolved
Copy link
Collaborator

@pattishin pattishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, confirmed that the triggers are still working as usual:

content-api
Screen Shot 2022-10-18 at 5 21 46 PM

website
Screen Shot 2022-10-18 at 5 29 14 PM

@pattishin pattishin merged commit 6f8ea4a into main Oct 19, 2022
@rogerthatdev rogerthatdev deleted the refactor/rename-triggers branch October 21, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: delivery Related to automation, testing, deployment of the application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants