Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

fix: terraform build trigger filename parameter #723

Merged
merged 2 commits into from
Dec 8, 2022
Merged

fix: terraform build trigger filename parameter #723

merged 2 commits into from
Dec 8, 2022

Conversation

rogerthatdev
Copy link
Contributor

@rogerthatdev rogerthatdev commented Dec 5, 2022 •
edited
Loading

This PR:

  • updates 4 google_cloudbuild_trigger resources in the emblem-app module to use the filename parameter instead of the git_file_source block

fixes #718

This causes no change to resources but will prevent Terraform anticipating changes upon re-run.

@github-actions github-actions bot added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. component: delivery Related to automation, testing, deployment of the application. labels Dec 5, 2022
@rogerthatdev rogerthatdev marked this pull request as ready for review December 8, 2022 02:01
@rogerthatdev rogerthatdev requested a review from a team as a code owner December 8, 2022 02:01
@github-actions github-actions bot added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 8, 2022
@rogerthatdev rogerthatdev changed the title fix: trigger filenames fix: terraform build trigger filename parameter Dec 8, 2022
@github-actions github-actions bot added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 8, 2022
ace-n
ace-n approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming it's been tested. 👍

@rogerthatdev rogerthatdev merged commit 338bacc into main Dec 8, 2022
@rogerthatdev rogerthatdev deleted the fix/trigger-filenames branch January 4, 2023 18:40
@github-actions github-actions bot mentioned this pull request Jan 26, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ace-n ace-n ace-n approved these changes

Assignees
No one assigned
Labels
component: delivery Related to automation, testing, deployment of the application. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rerunning terraform app module will always change triggers
2 participants
@rogerthatdev @ace-n