Api resource types #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
grayside
approved these changes
Jun 21, 2021
| @@ -0,0 +1,9 @@ | |||
| { | |||
There was a problem hiding this comment.
nit: Was this intended to be committed? If so perhaps it was meant for a test or docs directory?
There was a problem hiding this comment.
There's a file explaining how to exercise the API with curl commands. These two json files are sample data supporting those curl commands.
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "goal": 2000.00 | |||
| } | |||
There was a problem hiding this comment.
nit: was this meant to be committed?
grayside
added
component: content-api
|
I approved but we've also slid in a number of decisions like REST and PATCH method without decision records. Flagging that as necessary but I think the AI is to identify the decisions and file those as new issues. |
|
Test coverage is needed, as are documentation of decisions. One such decision is the behavior of PATCH and DELETE relative to etags. |
grayside
pushed a commit
that referenced
this pull request
Jul 22, 2021
* Added most of campaigns resource * All operations for campaigns and approvers * Causes and Donors added * Add resource types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All currently defined resource types now fully implemented. API enhancements likely are needed following up.