Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text in study builder forgot password screen #956

Closed
jkrogers18 opened this issue Sep 12, 2020 · 4 comments
Closed

Fix text in study builder forgot password screen #956

jkrogers18 opened this issue Sep 12, 2020 · 4 comments
Assignees
@harisboston
Labels
Bug Indicates that this issue describes something that isn't working as expected P1 High priority issue (must be done soon) Process: Tested dev This issue does not apply to the main branch, but is now working in develop. Study builder Issues related to the `Study builder` component
Milestone
Track 1

Comments

@jkrogers18
Copy link
Collaborator

jkrogers18 commented Sep 12, 2020 •
edited
Loading

  • Change "Enter your Email address to get a link to reset your password" to "Enter your email to receive a password reset link"
  • Remove period at end of the required field error message
  • Change "Back to Sign in" to "Back to sign in"
  • The confirmation messages that appear after clicking "submit" are displayed for 1 or 2 seconds, which is not enough time to read them. Is there a reason not to let those messages stay on the screen? I believe the copy of those messages needs to be adjusted but I cannot read or screenshot them fast enough to see.

Screenshot 2020-09-12 at 12 57 48 PM
@jkrogers18 jkrogers18 added the Bug Indicates that this issue describes something that isn't working as expected label Sep 12, 2020
@harisboston harisboston self-assigned this Sep 15, 2020
@jsolanki-btc jsolanki-btc assigned SR-btc and unassigned harisboston Oct 14, 2020
@SR-btc SR-btc assigned harisboston and unassigned SR-btc Dec 7, 2020
@SR-btc SR-btc added Process: Release 2 Track-1 Release-2 and removed Process: Release 2 Track-1 Release-2 labels Dec 7, 2020
harisboston added a commit that referenced this issue Dec 14, 2020
@harisboston
Fixed text in study builder forgot password screen #956
41873be 
Fixed text in study builder forgot password screen #956
@harisboston harisboston mentioned this issue Dec 14, 2020
Merged
harisboston added a commit that referenced this issue Dec 14, 2020
@harisboston
Merge pull request #2374 from GoogleCloudPlatform/study-builder-ui-is…
ea56e57 
…sue-958

Fixed issue #956 Fix text in study builder forgot password screen
@harisboston
Copy link
Collaborator

Fix is deployed in dev environment

@nishit-v nishit-v assigned Lathan-btc and unassigned nishit-v Dec 15, 2020
@Lathan-btc
Copy link
Collaborator

@harisboston Remove period at end of the required field error message -- reproducing

forgot password1

@Lathan-btc Lathan-btc removed their assignment Dec 15, 2020
@jkrogers18 jkrogers18 added Study builder Issues related to the `Study builder` component and removed Reopened labels Dec 16, 2020
@jkrogers18 jkrogers18 added this to the Track 1 Release 2 milestone Dec 16, 2020
@jkrogers18 jkrogers18 added the P1 High priority issue (must be done soon) label Dec 16, 2020
@harisboston
Copy link
Collaborator

@Lathan-btc Fix is deployed in dev environment.
Updated the error messages to be consistent "Please complete this field." as per issue #955.

@Lathan-btc
Copy link
Collaborator

Issue is resolved in latest Dev instance.

@Lathan-btc Lathan-btc added the Process: Tested dev This issue does not apply to the main branch, but is now working in develop. label Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harisboston harisboston

Labels
Bug Indicates that this issue describes something that isn't working as expected P1 High priority issue (must be done soon) Process: Tested dev This issue does not apply to the main branch, but is now working in develop. Study builder Issues related to the `Study builder` component
Projects
None yet
Milestone
Track 1
Development

No branches or pull requests
5 participants
@jkrogers18 @nishit-v @SR-btc @harisboston @Lathan-btc