Skip to content
This repository has been archived by the owner on Nov 5, 2022. It is now read-only.

Add session.Options values to cookie #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ebiiim
Copy link

@ebiiim ebiiim commented Dec 28, 2020

Just like the original implementations below, options (MaxAge, Path, etc...) should be set to the cookie.

https://github.com/gorilla/sessions/blob/9cb0b0a3e38d07f41143f03013eaf0a3243fb474/store.go#L102
https://github.com/gorilla/sessions/blob/9cb0b0a3e38d07f41143f03013eaf0a3243fb474/store.go#L210

This pull request solves #1.

@google-cla
Copy link

google-cla bot commented Dec 28, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ebiiim
Copy link
Author

ebiiim commented Dec 28, 2020

@googlebot I signed it!

@leobrines
Copy link

Hi! Will any revision be done?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants