Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add argument to add/remove x-csp header #39

Merged
merged 4 commits into from
May 15, 2019
Merged

add argument to add/remove x-csp header #39

merged 4 commits into from
May 15, 2019

Conversation

Heisendev
Copy link
Contributor

issue 38

#38

@coveralls
Copy link

coveralls commented May 15, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 65ed109 on MeilleursAgents:master into c45a9a5 on GoogleCloudPlatform:master.

theacodes
theacodes reviewed May 15, 2019
View reviewed changes
README.rst Outdated
@@ -103,6 +103,7 @@ Options
- ``content_security_policy_report_uri``, default ``None``, a string
indicating the report URI used for `CSP violation reports
<https://developer.mozilla.org/en-US/docs/Web/Security/CSP/Using_CSP_violation_reports>`_
- ``support_x_header``, default ``True``, Whether to add X-CSP header
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's call this legacy_content_security_policy_header. Yeah, it's verbose, but it fits with the rest of the options and makes it immediately obvious what this does. Might be useful to link to the page that describes the deprecated header.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done it in commit b688897 (also i linted the test_talisman file)

@theacodes
Copy link
Contributor

Thank you, @Heisendev!

@theacodes theacodes merged commit 24fd1a8 into GoogleCloudPlatform:master May 15, 2019
theacodes added a commit that referenced this pull request May 28, 2019
@theacodes
Release 0.7.0
80e24a0 
Changes:
- Remove pinned versions from example app dependencies (#41)
- add argument to add/remove x-csp header (#39)
- Use Nox instead of tox. (#37)
- Minor CSP specific updates. (#36)
- Fix typo in README.rst (#35)
@theacodes theacodes mentioned this pull request May 28, 2019
Merged
theacodes added a commit that referenced this pull request May 28, 2019
@theacodes
Release 0.7.0 (#42)
cae1475 
Changes:
- Remove pinned versions from example app dependencies (#41)
- add argument to add/remove x-csp header (#39)
- Use Nox instead of tox. (#37)
- Minor CSP specific updates. (#36)
- Fix typo in README.rst (#35)
@tunetheweb tunetheweb mentioned this pull request Jul 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Heisendev @coveralls @theacodes