Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add argument to add/remove x-csp header #39

Merged
merged 4 commits into from May 15, 2019

Conversation

Projects
None yet
3 participants
@Heisendev
Copy link
Contributor

commented May 15, 2019

issue 38

#38

@coveralls

This comment has been minimized.

Copy link

commented May 15, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 65ed109 on MeilleursAgents:master into c45a9a5 on GoogleCloudPlatform:master.

README.rst Outdated
@@ -103,6 +103,7 @@ Options
- ``content_security_policy_report_uri``, default ``None``, a string
indicating the report URI used for `CSP violation reports
<https://developer.mozilla.org/en-US/docs/Web/Security/CSP/Using_CSP_violation_reports>`_
- ``support_x_header``, default ``True``, Whether to add X-CSP header

This comment has been minimized.

Copy link
@theacodes

theacodes May 15, 2019

Member

Let's call this legacy_content_security_policy_header. Yeah, it's verbose, but it fits with the rest of the options and makes it immediately obvious what this does. Might be useful to link to the page that describes the deprecated header.

This comment has been minimized.

Copy link
@Heisendev

Heisendev May 15, 2019

Author Contributor

done it in commit b688897 (also i linted the test_talisman file)

Heisendev added some commits May 15, 2019

@theacodes

This comment has been minimized.

Copy link
Member

commented May 15, 2019

Thank you, @Heisendev!

@theacodes theacodes merged commit 24fd1a8 into GoogleCloudPlatform:master May 15, 2019

3 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

theacodes added a commit that referenced this pull request May 28, 2019

Release 0.7.0
Changes:
- Remove pinned versions from example app dependencies (#41)
- add argument to add/remove x-csp header (#39)
- Use Nox instead of tox. (#37)
- Minor CSP specific updates. (#36)
- Fix typo in README.rst (#35)

@theacodes theacodes referenced this pull request May 28, 2019

Merged

Release 0.7.0 #42

theacodes added a commit that referenced this pull request May 28, 2019

Release 0.7.0 (#42)
Changes:
- Remove pinned versions from example app dependencies (#41)
- add argument to add/remove x-csp header (#39)
- Use Nox instead of tox. (#37)
- Minor CSP specific updates. (#36)
- Fix typo in README.rst (#35)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.