-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Fluentd v1 API #45
Conversation
Do I need fixing code to pass rubocop checks? |
@qingling128 I recall you looked into the fluentd API migration. Is this something we want to commit? |
@jkohen - Yes. We should include this in |
This is needed to allow implementations to use fluentd gracefulReload API endpoint. Will fix this issue #77 . Can we get some priority on getting this merged? |
Is this going to be merge in at some point to support new gracefullReload API endpoint? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
- fixing missing code to make v1 API commit work with upstream changes - fixing functions for new parameter force_line_breaks - fixing rubocop errors and exanded lineLength to 100 chars - all tests pass on ruby 2.7.4 - this combines GoogleCloudPlatform#45 (resolves GoogleCloudPlatform#45) and reconciles it for the latest code changes in upstream Signed-off-by: Cryptophobia <aouzounov@vmware.com>
Please close this one as it does not conform to latest code changes since the PR is old. #93 is tested and working with latest code. I fixed rake test errors and all tests passing on ruby 2.7.4 . Going to test this out in dev, staging. |
- fixing missing code to make v1 API commit work with upstream changes - fixing functions for new parameter force_line_breaks - fixing rubocop errors and exanded lineLength to 100 chars - all tests pass on ruby 2.7.4 - this combines GoogleCloudPlatform#45 (resolves GoogleCloudPlatform#45) and reconciles it for the latest code changes in upstream Signed-off-by: Cryptophobia <aouzounov@gatech.edu>
Please read "Updating Plugins Overview" before release
new version of this plugin.
See https://docs.fluentd.org/v1.0/articles/plugin-update-from-v0.12