Accept structured logs data over TCP by default.

[bokowski]

To collect application-level logs, the fluentd documentation recommends
using the forward input plugin for all languages except PHP, see
http://docs.fluentd.org/v0.12/categories/logging-from-apps. By adding
this file, the story for sending application-level logs to Cloud Logging
becomes much easier.

[igorpeshansky]

This is the default, isn't it? Does it still make sense to set it explicitly?
@mr-salty for comment.

[bokowski]

I thought it did make sense - we are asking users to edit the files in that
directory as necessary, and including the default in the file makes it
easier to see right there what the default is, and to decide whether it
needs to be changed. Otherwise, users will have to find the documentation
that's in a totally different spot.

On Thu, 2 Jun 2016, 18:57 igorpeshansky, notifications@github.com wrote:

In configs/config.d/forward.conf
#7 (comment)
:

@@ -0,0 +1,6 @@
+

• @type forward
• port 24224

This is the default, isn't it? Does it still make sense to set it
explicitly?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/fluentd-catch-all-config/pull/7/files/d87ae65a65f4452413bbbbacd3f0b242fba327c2#r65577922,
or mute the thread
https://github.com/notifications/unsubscribe/AALxtGnuVR7pHv2o0qXxrkJuK0dO1Yb0ks5qHwuUgaJpZM4Iez4l
.

[igorpeshansky]

I would at least add a "# Default." comment to this line. The problem is that other tools will attempt to connect to this port, so it makes sense to communicate to the user that changing this not advisable.

[bokowski]

Good point. I've added a comment saying that this is the default port.

[igorpeshansky]

Ok, can you please squash the two commits? Otherwise LGTM.

[mr-salty]

FYI @igorpeshansky github now allows you to squash commits during merge, it's a fairly recent feature: https://github.com/blog/2141-squash-your-commits

[igorpeshansky]

@mr-salty, doesn't look like this repo is configured to allow it. Plus, it's not at all clear from the documentation whether the authorship of the resulting commit will be retained.