Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

Servicemanagement client update #2175

Merged
merged 6 commits into from
Nov 2, 2018
Merged

Conversation

bobklein2
Copy link
Contributor

Thanks for opening a Pull Request!

Here's a handy checklist to ensure your PR goes smoothly.

  • [ X ] I signed Google's Contributor License Agreement
  • [ X ] My code conforms to Google's python style.
  • [ X ] My PR at a minimum doesn't decrease unit-test coverage (if applicable).
  • [ X ] My PR has been functionally tested.
  • [ X ] All of the unit-tests still pass.
  • [ X ] Running pylint --rcfile=pylintrc passes.

These guidelines and more can be found in our contributing guidelines.

@codecov
Copy link

codecov bot commented Nov 2, 2018

Codecov Report

Merging #2175 into dev will decrease coverage by <.01%.
The diff coverage is 90%.

@@            Coverage Diff             @@
##              dev    #2175      +/-   ##
==========================================
- Coverage   88.75%   88.75%   -0.01%     
==========================================
  Files         173      173              
  Lines       13128    13163      +35     
==========================================
+ Hits        11652    11683      +31     
- Misses       1476     1480       +4
Impacted Files Coverage Δ
.../cloud/forseti/common/gcp_api/servicemanagement.py 94.73% <90%> (-5.27%) ⬇️

Copy link
Collaborator

@ahoying ahoying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Bob for getting this into Forseti!

@ahoying ahoying merged commit a071f95 into dev Nov 2, 2018
@ahoying ahoying deleted the servicemanagement-client-update branch November 2, 2018 14:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants