Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

Initialize All Tables #536

Merged
merged 4 commits into from
Aug 4, 2017
Merged

Initialize All Tables #536

merged 4 commits into from
Aug 4, 2017

Conversation

blueandgold
Copy link
Contributor

Ensure all the tables are created, to support client usages & joins, which expect the tables to exist even if empty.

@codecov
Copy link

codecov bot commented Aug 4, 2017

Codecov Report

Merging #536 into dev will decrease coverage by 0.03%.
The diff coverage is 28.57%.

@@            Coverage Diff            @@
##             dev     #536      +/-   ##
=========================================
- Coverage   81.2%   81.17%   -0.04%     
=========================================
  Files        156      156              
  Lines       7518     7521       +3     
=========================================
  Hits        6105     6105              
- Misses      1413     1416       +3
Impacted Files Coverage Δ
...oogle/cloud/security/inventory/inventory_loader.py 33.33% <0%> (-0.75%) ⬇️
...cloud/security/common/data_access/violation_dao.py 83.72% <100%> (ø) ⬆️
google/cloud/security/common/data_access/dao.py 61.29% <33.33%> (ø) ⬆️

@mirons-google
Copy link
Contributor

Approved, but it would be nice to include test coverage for this and anything else here you're willing to do.

@blueandgold
Copy link
Contributor Author

Let me punt on the testing here as this whole piece might be changing soon. Thanks!

@blueandgold blueandgold merged commit b108751 into dev Aug 4, 2017
@blueandgold blueandgold deleted the initialize_table branch August 4, 2017 19:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants