Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: describe how to run a local server #209

Merged

Conversation

coryan
Copy link
Member

@coryan coryan commented Feb 2, 2021

Part of the work for #202

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #209 (ccbe75f) into main (48121de) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #209   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files          73       73           
  Lines        1799     1799           
=======================================
  Hits         1735     1735           
  Misses         64       64           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48121de...753f959. Read the comment docs.

@coryan coryan marked this pull request as ready for review February 2, 2021 23:03
@coryan coryan requested a review from a team as a code owner February 2, 2021 23:03

The Functions Framework for C++ recommends using [vcpkg][vcpkg-gh] to manage
dependencies. This is how dependencies will be installed and compiled in the
production environment, you probably want to use the same approach in
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/you/so you/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks.

.build/quickstart --port 8080
```

Test this program using `curl`, in a separate shell run:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/, in/. In/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@coryan coryan merged commit d63f473 into GoogleCloudPlatform:main Feb 3, 2021
@coryan coryan deleted the doc-howto-guides-local-development branch February 3, 2021 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants