refactor: use vcpkg features to control dependencies #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes we want to compile without the tests, or without the tests for the examples. With this change we can express that by just turning vcpkg features on or off. Because `-DBUILD_TESTING=ON` is a well-known flag, we use it to enable the testing features too.
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## main #289 +/- ##
==========================================
+ Coverage 88.55% 88.57% +0.02%
==========================================
Files 87 87
Lines 2255 2259 +4
==========================================
+ Hits 1997 2001 +4
Misses 258 258
Continue to review full report at Codecov.
|
|
This is ready for review now. To see this in action, look at #290. |
devjgm
approved these changes
Feb 20, 2021
coryan
deleted the
refactor-use-vcpkg-features-to-control-dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we want to compile without the tests, or without the tests for
the examples. With this change we can express that by just turning vcpkg
features on or off. Because
-DBUILD_TESTING=ONis a well-known flag,we use it to enable the testing features too.