Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: examples use declarative configuration 3/N #369

Merged

Conversation

coryan
Copy link
Member

@coryan coryan commented Jul 4, 2023

Part of the work for #345

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #369 (c1fdc6d) into main (9761987) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head c1fdc6d differs from pull request most recent head c1caa33. Consider uploading reports for the commit c1caa33 to get more accurate results

@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
+ Coverage   88.91%   88.96%   +0.04%     
==========================================
  Files          97       97              
  Lines        3031     3044      +13     
==========================================
+ Hits         2695     2708      +13     
  Misses        336      336              
Impacted Files Coverage Δ
...concepts_after_response/concepts_after_response.cc 100.00% <100.00%> (ø)
...e/concepts_after_timeout/concepts_after_timeout.cc 100.00% <100.00%> (ø)
...es/site/concepts_filesystem/concepts_filesystem.cc 100.00% <100.00%> (ø)
examples/site/concepts_request/concepts_request.cc 100.00% <100.00%> (ø)
...ples/site/concepts_stateless/concepts_stateless.cc 100.00% <100.00%> (ø)
examples/site_test.cc 98.52% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@coryan coryan marked this pull request as ready for review July 4, 2023 19:27
@coryan coryan requested a review from a team as a code owner July 4, 2023 19:27
@coryan coryan merged commit 6a9c412 into GoogleCloudPlatform:main Jul 4, 2023
21 checks passed
@coryan coryan deleted the doc-declarative-examples-pr3 branch July 4, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants