Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples/raw_cloudevent to use official image #229

Closed
subfuzion opened this issue May 18, 2021 · 8 comments · Fixed by #230
Closed

Update examples/raw_cloudevent to use official image #229

subfuzion opened this issue May 18, 2021 · 8 comments · Fixed by #230
Assignees
Labels
kind/bug Something isn't working

Comments

@subfuzion
Copy link
Member

Will need to take a look at builder framework internals for 'Iterable<Object?>', which does not match the return type, 'Iterable<Object>', of the overridden method, 'StructuredSerializer.serialize'

@kevmoo
Copy link
Collaborator

kevmoo commented May 18, 2021

How do I reproduce this?

@subfuzion
Copy link
Member Author

Update the Dockerfile like the other examples to use the official image, try and build.

@subfuzion
Copy link
Member Author

I just looked at it again, looks like the current example probably hasn't been working for a while:

dart run build_runner build --delete-conflicting-outputs

Output:

$ dart run build_runner build --delete-conflicting-outputs
Precompiling executable... (5.4s)
Failed to precompile build_runner:build_runner:
...

@subfuzion subfuzion added the kind/bug Something isn't working label May 18, 2021
@subfuzion
Copy link
Member Author

This is the commit that breaks the example: 79e4e4fd (PR #219).

@kevmoo
Copy link
Collaborator

kevmoo commented May 18, 2021 via email

@subfuzion
Copy link
Member Author

I have. And the image doesn't build either, so that shouldn't be my environment. Anyway, why don't you just update the sample (as I originally asked) and if it works for you, then that's great. I updated the other samples.

@subfuzion
Copy link
Member Author

subfuzion commented May 18, 2021

So git clean fdx fixed the issue for me:

$ git clean -fdx
Removing .dart_tool/
Removing .packages
Removing pubspec.lock

But since the .dockerignore ensures that the first two weren't included in the docker build context, it seems that removing pubspec.lock is what needed to be done to fix.

So this makes me realize that we're versioning an application, but we're not committing the lock file.

I'll add the lock file with an update for the example. Otherwise, the fix is to run dart pub upgrade to force Dart to update it.

@subfuzion
Copy link
Member Author

Reopening. Will close this with #230.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants