Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudevent example use official image #230

Merged
merged 4 commits into from May 18, 2021

Conversation

subfuzion
Copy link
Member

@subfuzion subfuzion commented May 18, 2021

This example updates examples/raw_cloudevent. It also addresses an issue I noted because we weren't committing pubspec.lock files with the sample apps. It removes the top level .gitignore and .dockerignore files and places them individually tailored for the library packages and sample applications.

Closes #229

@subfuzion subfuzion requested a review from kevmoo May 18, 2021 03:45
@subfuzion subfuzion linked an issue May 18, 2021 that may be closed by this pull request
@subfuzion subfuzion requested a review from grant May 18, 2021 16:25
Copy link

@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=)

@subfuzion subfuzion merged commit e5f9b13 into main May 18, 2021
@subfuzion subfuzion deleted the cloudevent-example-use-official-image branch May 18, 2021 16:57
Copy link
Collaborator

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm...ambivalent about including the lock files here.

That means we'll have to update these ~often or users won't be getting the latest dependencies.

@subfuzion
Copy link
Member Author

I see your point of view. We already had a separate discussion with @mit-mit and I also agreed with following recommended best practices for apps and committing the lock file. When we don't, we run into issues like I did with #229 where a lock file on the users system is out-of-date (and isn't overwritten when pulling the latest). This PR is merged, so let's can continue the discussion in a new issue.

@mit-mit
Copy link
Contributor

mit-mit commented May 18, 2021

Why are you ambivalent @kevmoo? These are apps, right?

@kevmoo
Copy link
Collaborator

kevmoo commented May 18, 2021

Why are you ambivalent @kevmoo? These are apps, right?

Yes...but they are samples. "pinning" deps for something actively maintained in a team totally makes sense.

For samples...it feels weird.

@mit-mit
Copy link
Contributor

mit-mit commented May 18, 2021

Say more. How does it feel weird? Is there some practical issue?

@kevmoo
Copy link
Collaborator

kevmoo commented May 18, 2021

Say more. How does it feel weird? Is there some practical issue?

Sorry for being vague.

We want our users to get the latest dependencies, generally. For a deployed app, saving the .lock file makes sense.

This seems like noise. PRs that are just "update deps" are noisy. maybe it's just something I need to get used to. It's a feeling at the moment, but I don't have anything specific to pin it on. Sorry! 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update examples/raw_cloudevent to use official image
5 participants