Don't register SIGTERM handler on Windows #153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #151
Registering a SIGTERM handler on Windows raises an exception.
@kevmoo PTAL. Things to consider: this explicitly checks for Windows, but it might be better to just try to catch the exception and then log that the SIGTERM handler couldn't be registered for the host OS.
Before merging this, we should get someone with Windows expertise to weigh in. I left this comment in the issue, copied here for convenience:
This might or might not be the appropriate fix. There might be an issue with Dart? According to this Microsoft doc, Windows includes
SIGTERM
for ANSI compatibility: