Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment documentation #64

Merged
merged 1 commit into from May 21, 2020

Conversation

jskeet
Copy link
Member

@jskeet jskeet commented May 1, 2020

No description provided.

Copy link
Member

@amanda-tarafa amanda-tarafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


## Deploying locally

Your function can run locally either by starting it through Visual
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it depends on the Invoker or a custom invoker, seems evident to us but might not be to everyone.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

- [Codelab for C#](https://codelabs.developers.google.com/codelabs/cloud-run-hello-csharp/index.html)

The instructions apply to functions in exactly the same way as
normal, with the same Dockerfile configuration. The `PORT`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is weird: in exactly the same way as a normal, ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed - but check that it's clear :)

## Deploying to Google Cloud Functions

> **NOTE:**
> The `dotnet3` runtime is currently available on an "allow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are instructions on how to get whitelisted, or at least a note on who gets whitelisted, we can avoid people asking.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. This is a bit ominous.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a bit here. PTAL.

The command line options are used to specify how the function is
triggered.

### HTTP functions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No section for Cloud Events?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed "legacy event" to "Cloud Event" now that that's all we have.

@amanda-tarafa
Copy link
Member

A couple of my comments here had already been replied to in the bigger PR so ignore here.

## Deploying to Google Cloud Functions

> **NOTE:**
> The `dotnet3` runtime is currently available on an "allow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. This is a bit ominous.

------------------------ | -------------- | --------------------------
Cloud Storage operation | StorageObject | --trigger-event google.storage.object.finalize --trigger-resource ***my-gcs-bucket***
Pub/Sub message | PubSubMessage | --trigger-topic ***my-pubsub-topic-id***
Firestore event | FirestoreEvent | --trigger event providers/cloud.firestore/eventTypes/document.write --trigger-resource 'projects/***my-project***/databases/(default)/documents/***my-collection***/{document}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a dash missing? --trigger event .

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted - fixed, thanks.

Copy link
Member Author

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review comments addressed - PTAL.

(Grant: I'll merge if Amanda is happy; we can always make further changes.)


## Deploying locally

Your function can run locally either by starting it through Visual
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

- [Codelab for C#](https://codelabs.developers.google.com/codelabs/cloud-run-hello-csharp/index.html)

The instructions apply to functions in exactly the same way as
normal, with the same Dockerfile configuration. The `PORT`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed - but check that it's clear :)

## Deploying to Google Cloud Functions

> **NOTE:**
> The `dotnet3` runtime is currently available on an "allow
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a bit here. PTAL.

The command line options are used to specify how the function is
triggered.

### HTTP functions
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed "legacy event" to "Cloud Event" now that that's all we have.

------------------------ | -------------- | --------------------------
Cloud Storage operation | StorageObject | --trigger-event google.storage.object.finalize --trigger-resource ***my-gcs-bucket***
Pub/Sub message | PubSubMessage | --trigger-topic ***my-pubsub-topic-id***
Firestore event | FirestoreEvent | --trigger event providers/cloud.firestore/eventTypes/document.write --trigger-resource 'projects/***my-project***/databases/(default)/documents/***my-collection***/{document}'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted - fixed, thanks.

Copy link
Member

@amanda-tarafa amanda-tarafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jskeet jskeet merged commit bd156e5 into GoogleCloudPlatform:master May 21, 2020
@jskeet jskeet deleted the just-deploy-docs branch May 21, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants