Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: extract cloudevents functions, privateize file-global identifiers #138

Merged
merged 2 commits into from
May 12, 2020
Merged

refactor: extract cloudevents functions, privateize file-global identifiers #138

merged 2 commits into from
May 12, 2020

Conversation

grant
Copy link
Contributor

@grant grant commented May 12, 2020

  • Moves getBinaryCloudEventContext into src/cloudevents.ts
  • Inlines global rawBodySaver method (not really needed outside getServer
  • Cleans up a few comments

@grant
refactor: extract cloudevents functions, privateize file-global ident…
7a1786f 
…ifiers

Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant grant requested a review from hdp617 May 12, 2020 18:48
@grant grant self-assigned this May 12, 2020
@grant
style: fix lint issues
a394dd6 
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant
Copy link
Contributor Author

grant commented May 12, 2020

Last part of #134.

@grant grant merged commit 5bf1ad1 into master May 12, 2020
@grant grant deleted the grant_refactor_invoker branch May 12, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdp617 hdp617 hdp617 approved these changes

Assignees

@grant grant

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grant @hdp617 @googlebot