Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CloudEvents v1.0 in CloudEventsContext and tests #139

Merged
merged 3 commits into from
May 14, 2020
Merged

Use CloudEvents v1.0 in CloudEventsContext and tests #139

merged 3 commits into from
May 14, 2020

Conversation

hdp617
Copy link
Contributor

@hdp617 hdp617 commented May 14, 2020

No description provided.

@hdp617
docs: Fix link to the CloudEvents spec
ea20520
@hdp617
fix: Use CloudEvents v1.0 in CloudEventsContext and tests
3a1b950 
CloudEvents v1.0 has renamed `schemaurl` to `dataschema` and `contenttpye` to `datacontenttype` and added subject. `CloudEventsContext` is updated with the v1.0 attributes.
CloudEvents tests are also updated to use valid values.

Resolves: #132, #133
@hdp617 hdp617 requested a review from grant May 14, 2020 01:24
grant
grant approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@grant grant left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part. 1 nit.

test/invoker.ts Outdated Show resolved Hide resolved
@hdp617
fix: Remove the dataschema attribute
7ab4fc2 
The current value is not the true dataschema of the payload.
@hdp617 hdp617 merged commit bf6e20e into GoogleCloudPlatform:master May 14, 2020
@hdp617 hdp617 deleted the cloudevents branch May 14, 2020 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grant grant grant approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hdp617 @grant @googlebot